Never mind. After leaving it for a while, then coming back and adding more strategic HTML comments with more therapeutic swearing, I have tracked it all down.
If the posting options are displayed (Disable BBCode, etc.) the closing tags in posting_editor.html (lines 95-98 inclusive) close #postingbox and #postingbox > .inner, while the closing tags in posting_layout.html get hijacked to close #options-panel and #options-panel .inner.
If the attachments options are displayed, having #options-panel set to display: none; means it takes the closing tags from posting_layout.html with it. This is why #attach-panel brings its own closing tags with it (#postingbox and #postingbox > .inner are still closed by the two tags in posting_editor.html).
If nothing is displayed (no posting options or attachment options) #postingbox and #postingbox > .inner use the two closing tags from posting_layout.html.
Ok, it works, if you want to keep everything the same as Prosilver, but by God it's a fragmented and convoluted way of doing things, and not at all friendly to customisation. It reminds me of what someone said to me once: "I hate Prosilver. It's only good at being Prosilver, and terrible for anything else".
So, now I can rewrite the whole shebang to make it do what I want it to do, and so it will be clearer and more flexible if I want to change anything in future. Since #tabs, #options-panel, and #attach-panel are separate from #postingbox anyway, and since #attach-panel already has its own dedicated modular template, the sanest option is probably to treat #tabs, #options-panel the same way. Or, alternatively, just pull them out of posting_editor.html and add them to posting_attach_body.html, which I can then rename to all_the_shiznit_that_doesnt_belong_in_posting_editor.html Image may be NSFW.
Clik here to view.
If the posting options are displayed (Disable BBCode, etc.) the closing tags in posting_editor.html (lines 95-98 inclusive) close #postingbox and #postingbox > .inner, while the closing tags in posting_layout.html get hijacked to close #options-panel and #options-panel .inner.
If the attachments options are displayed, having #options-panel set to display: none; means it takes the closing tags from posting_layout.html with it. This is why #attach-panel brings its own closing tags with it (#postingbox and #postingbox > .inner are still closed by the two tags in posting_editor.html).
If nothing is displayed (no posting options or attachment options) #postingbox and #postingbox > .inner use the two closing tags from posting_layout.html.
Ok, it works, if you want to keep everything the same as Prosilver, but by God it's a fragmented and convoluted way of doing things, and not at all friendly to customisation. It reminds me of what someone said to me once: "I hate Prosilver. It's only good at being Prosilver, and terrible for anything else".
So, now I can rewrite the whole shebang to make it do what I want it to do, and so it will be clearer and more flexible if I want to change anything in future. Since #tabs, #options-panel, and #attach-panel are separate from #postingbox anyway, and since #attach-panel already has its own dedicated modular template, the sanest option is probably to treat #tabs, #options-panel the same way. Or, alternatively, just pull them out of posting_editor.html and add them to posting_attach_body.html, which I can then rename to all_the_shiznit_that_doesnt_belong_in_posting_editor.html Image may be NSFW.
Clik here to view.
Statistics: Posted by Gumboots — Tue Sep 03, 2024 5:44 am
